-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest block time and spendable resources with exclusion #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add README FAQ instructions for how to run the docs locally - Hide blank debugging pages from nav - Reorganize navigation so the "Getting Started" section is not bloated - Add a page for testing basics --------- Co-authored-by: Halil Beglerović <git@hal3e.io> Co-authored-by: Ahmed Mujkic <32431923+MujkicA@users.noreply.github.com>
Enable the users to add a custom asset to contract calls by providing an asset_id, amount, and an optional address for the recipient of the generated outputs. closes #803
Co-authored-by: Ahmed Sagdati <ahmed.sagdati.ets@gmail.com>
Co-authored-by: Ahmed Mujkic <ahmedmujkic2@gmail.com>
Update `fuels-rs` to the latest `fuel-core 0.16.1` and latest `sway 0.34.0`. Due to changes in `fuel-asm` for GTF, this is causing yet another circular upgrade issue. - Used `{ workspace = true }` syntax to use one version across the project and simplify integration with new changes in the future. - Added `ci_checks.sh` script to compile all tests to simplify integration of changes like this in the future. - Update contracts to be compatible with `sway 0.34.0`. - Updated tests to be compatible with `fuel-core 0.16.1`. related PR: FuelLabs/sway#3961 --------- Co-authored-by: green <xgreenx9999@gmail.com>
This fixes the current CI issue we have.
###### Description of changes Consolidate common package metadata fields into the workspace root (e.g. version, license, authors)
###### Description of changes Adds a step to dry run the publish crates action to help identify potential issues before publishing Also removes usage of the deprecated rust-action Simplifies tag version validation
###### Description of changes Utilize workspace package to bump most crate versions in a single file
…819) Abigen moved into a new crate named `fuels-code-gen` so that the indexer team might use it.
add error handling section for the Call response page in the docs
Closes #742 Forwarding CallParameters with an amount > 0 to a method that is not annotated as payable results in a AssetsForwardedToNonPayableMethod error. BREAKING CHANGE: `.call_params()` now returns a Result --------- Co-authored-by: Halil Beglerović <git@hal3e.io> Co-authored-by: Ahmed Sagdati <ahmed.sagdati.ets@gmail.com>
….26. (#827) This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The aim is to propagate this last API-breaking update through fuels-rs and sway before beta-3. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream and the [patch] table is removed in this PR, this unblocks the associated sway update PR here: FuelLabs/sway#4004. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
###### Description of changes Release breaking change for new fuel-asm library
Abigen with `no_std` should now be wasm friendly and use the fuels crates directly instead of through `fuels` which causes non-wasm compatible dependencies to be included atm.
iqdecay
previously requested changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions, looking good!
hal3e
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review with @segfault-magnet. Looks good. Left some nits
Co-authored-by: Halil Beglerović <git@hal3e.io>
segfault-magnet
approved these changes
Feb 27, 2023
digorithm
reviewed
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #832
This PR changes
provider.get_spendable_resources
to accept a filter which let's you define the target asset, amount, owner and also specify excluded resource ids.It also adds
provider.get_inputs_for_filter
which works similarly towallet.get_inputs_for_amount
but with the advantage of being able to specify excluded ids.It also adds a convenience method to the provider to retrieve the latest block time.
While implementing the above, I made a bug which wasn't caught by our tests.
Because of that, I also added a test for
wallet.transfer()
for transferring asset ids other than the base asset.