New feature Fb::Page#insights pending review. #4
Conversation
|
Coverage remained the same at 100.0% when pulling dbc40caa4c742df3a091b01bf2b5742ca86a0938 on insights into d3ccea3 on master. |
lib/fb/insight_request.rb
Outdated
There was a problem hiding this comment.
I can merge request.run.body here instead of just the response code, but I think this is easier to test or find failed requests.
lib/fb/metric.rb
Outdated
There was a problem hiding this comment.
I find that I need to use symbolize_keys in many places and they're not necessarily a resource. I think we could make a helper module instead.
lib/fb/metric.rb
Outdated
There was a problem hiding this comment.
Should I have Day as a private class or just use OpenStruct? Using symbolize_key in combination with parsing end_time is a problem for a OpenStruct one liner.
lib/fb/page.rb
Outdated
There was a problem hiding this comment.
format and format_metric should problem go in another class since other resources (e.g. videos) will use it too. It will here for now. The next resources that require insights are posts which is still part of Page.
|
Coverage remained the same at 100.0% when pulling 3182e684c28ebfa406319f815bdc97008a56d0a2 on insights into d3ccea3 on master. |
lib/fb/page.rb
Outdated
No description provided.