Skip to content

Conversation

whitead
Copy link
Collaborator

@whitead whitead commented Sep 24, 2025

Allowing JSON mode to bail out on summarizing, like we allow in non-json mode

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Sep 24, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables JSON mode summarization to handle irrelevant content by allowing empty summaries, matching the behavior already present in non-JSON mode.

  • Extends relevance score range from 1-10 to 0-10 to include a "not relevant" option
  • Adds explicit instructions for handling irrelevant excerpts with empty summaries and zero relevance scores

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

dosubot bot commented Sep 24, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2025
@jamesbraza jamesbraza self-requested a review September 24, 2025 17:20
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 26, 2025
@jamesbraza jamesbraza merged commit 11b7fcb into main Sep 26, 2025
5 checks passed
@jamesbraza jamesbraza deleted the json-change branch September 26, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants