Skip to content

Replace raise_for_status return None with Mock() in clinical trials test #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

Replace raise_for_status return None with Mock() in clinical trials test #785

merged 1 commit into from
Jan 3, 2025

Conversation

mskarlin
Copy link
Collaborator

@mskarlin mskarlin commented Jan 3, 2025

Two of our tests were trying to overwrite the return in response.raise_for_status, which pytest expected to be async, this fixes that.

@mskarlin mskarlin requested a review from jamesbraza January 3, 2025 18:26
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 3, 2025
jamesbraza
jamesbraza approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2025
@mskarlin mskarlin merged commit 8548b7a into main Jan 3, 2025
4 of 5 checks passed
@mskarlin mskarlin deleted the fix-warnings-in-clinical-trials-test branch January 3, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mskarlin @jamesbraza