Skip to content

Replace raise_for_status return None with Mock() in clinical trials test #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Replace raise_for_status return None with Mock() in clinical trials test #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_clinical_trials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def mock_session():
@pytest.mark.asyncio
async def test_api_search_clinical_trials_success(mock_session):
mock_response = AsyncMock(status=200)
mock_response.raise_for_status.return_value = None
mock_response.raise_for_status = Mock()
mock_response.text.return_value = json.dumps({"studies": [SAMPLE_TRIAL_DATA]})
mock_response.json.return_value = {"studies": [SAMPLE_TRIAL_DATA]}
mock_session.get.return_value.__aenter__.return_value = mock_response
Expand All @@ -52,18 +52,20 @@ async def test_api_search_clinical_trials_success(mock_session):

assert result == {"studies": [SAMPLE_TRIAL_DATA]}
mock_session.get.assert_called_once()
mock_response.raise_for_status.assert_called_once()


@pytest.mark.asyncio
async def test_api_get_clinical_trial_success(mock_session):
mock_response = AsyncMock()
mock_response.raise_for_status.return_value = None
mock_response.raise_for_status = Mock()
mock_response.json.return_value = SAMPLE_TRIAL_DATA
mock_session.get.return_value.__aenter__.return_value = mock_response

result = await api_get_clinical_trial("NCT12345678", mock_session)

assert result == SAMPLE_TRIAL_DATA
mock_response.raise_for_status.assert_called_once()


@pytest.mark.asyncio
Expand Down
Loading