Add SLES15 as a platform

[Dooruk]

It is finally happening....

... this will require some changes in the .swell and .cylc folders.

[Dooruk]

I'm proposing not using .swell/slurm-swell.yaml and moving it under platforms (which is already done but I forgot to explain my rationale), so the user would need to use the -s option unless we set the account etc. NCCS Discover generic.

Just need to fix the mock test next..

[Dooruk]

@ashiklom this is ready for a review. I commented out user_globals, so I'm proposing having global_defaults in platforms, nothing in the $HOME directory (now that we have them in platforms, no need for user_globals), with the -s option for the user during swell create. Hence, I had to comment out lines from the code_tests please take a look when you have a chance.

I had to introduce platform in both code_test and the slurm utility but we might need a more elegant solution..

[Dooruk]

I had to add a unit_test switch to prepare_scheduling_dict to allow platform catch conditional to work but looks good on my end.

[Dooruk]

Can I get that approval now 😄

[Dooruk]

Hmm, since we are not using the global swell-slurm.yaml anymore, gmao_ci automatically uses the default settings. That is one minor issue but that's related to how our Github actions are setup currently.

But thinking about it further, this will impact other users too, unless they include this in their -s slurm-override.yaml.

[ashiklom]

Hmm, since we are not using the global swell-slurm.yaml anymore, gmao_ci automatically uses the default settings. That is one minor issue but that's related to how our Github actions are setup currently.

But thinking about it further, this will impact other users too, unless they include this in their -s slurm-override.yaml.

Yes, removing the user_globals / ~/.swell/swell-slurm.yaml is a breaking change, and not necessarily a necessary one for this feature. I think keeping user_globals around is safer --- there are platform-agnostic but still useful ways to set the user-specific defaults (most importantly, setting your user account), and it can always be overridden by -s slurm.yaml, so it's easy to soft-deprecate it gradually (rather than ripping it out abruptly). It's also consistent with how other SLURM-related software does things; e.g., Dask jobqueue.

Personally, my vote would be to bring user_globals back. But if you decide to leave it out, a simple fix to the CI would be to add -s /home/gmao_ci/.swell/swell-slurm.yaml to every swell create command in the CI.

[Dooruk]

Personally, my vote would be to bring user_globals back. But if you decide to leave it out, a simple fix to the CI would be to add -s /home/gmao_ci/.swell/swell-slurm.yaml to every swell create command in the CI.

Ok, I revived user_globals and now we have not just one but two mock tests!