Add ability to specify "multiple highlights" or bookmarks #668

Merged
merged 22 commits into from Feb 23, 2016

Conversation

Projects
None yet
3 participants
@cmdcolin
Contributor

cmdcolin commented Dec 8, 2015

This adds a couple functions to essentially have "multiple highlights". The highlights can have labels and can be different colors (maybe they are like bookmarks). You can define the bookmarks in a config file, on the URL bar, or via a web service.

I think originally the idea of multiple highlights was brought up here #482

Each bookmark has

start (int), end (int), ref (string)

Optional params

color (string for css compatible color)
label (string for label on left side)
rlabel (string for label on right side)

@cmdcolin cmdcolin removed the in progress label Dec 10, 2015

nathandunn added a commit that referenced this pull request Feb 23, 2016

Merge pull request #668 from GMOD/multiple_highlights
Add ability to specify "multiple highlights" or bookmarks

@nathandunn nathandunn merged commit 5b0477e into master Feb 23, 2016

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Feb 24, 2016

Contributor

Let me know if there are any bugs/needed additions for this. I had one more commit that sort of reorganized the code but it might not be necessary. Also @erasche picked this up and added some stuff to the jbrowse configuration guide http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks

Contributor

cmdcolin commented Feb 24, 2016

Let me know if there are any bugs/needed additions for this. I had one more commit that sort of reorganized the code but it might not be necessary. Also @erasche picked this up and added some stuff to the jbrowse configuration guide http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks

@nathandunn

This comment has been minimized.

Show comment
Hide comment
@nathandunn

nathandunn Feb 24, 2016

Contributor

Most likely any commits I make to it will go away.

What I need is another LocationScaleTrack in GenomeView, but that will come later, . . but not going to do that right now. If you want to re-organize and create another pull request that would be fine.

Nathan

On Feb 23, 2016, at 4:13 PM, Colin Diesh notifications@github.com wrote:

Let me know if there are any bugs/needed additions for this. I had one more commit that sort of reorganized the code but it might not be necessary. Also @erasche https://github.com/erasche picked this up and added some stuff to the jbrowse configuration guide http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks

Reply to this email directly or view it on GitHub #668 (comment).

Contributor

nathandunn commented Feb 24, 2016

Most likely any commits I make to it will go away.

What I need is another LocationScaleTrack in GenomeView, but that will come later, . . but not going to do that right now. If you want to re-organize and create another pull request that would be fine.

Nathan

On Feb 23, 2016, at 4:13 PM, Colin Diesh notifications@github.com wrote:

Let me know if there are any bugs/needed additions for this. I had one more commit that sort of reorganized the code but it might not be necessary. Also @erasche https://github.com/erasche picked this up and added some stuff to the jbrowse configuration guide http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks http://gmod.org/wiki/JBrowse_Configuration_Guide#addBookmarks

Reply to this email directly or view it on GitHub #668 (comment).

@cmdcolin cmdcolin deleted the multiple_highlights branch Feb 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment