Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canMergeChunks for of index blocks calculation to avoid too large of blocks #121

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

cmdcolin
Copy link
Contributor

This adds the canMergeBlocks from bam-js to tabix to avoid too large of blocks being downloaded

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #121 (91b54c7) into master (962e5b4) will decrease coverage by 0.72%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   90.74%   90.01%   -0.73%     
==========================================
  Files           7        7              
  Lines         551      531      -20     
  Branches      150      147       -3     
==========================================
- Hits          500      478      -22     
- Misses         51       53       +2     
Impacted Files Coverage Δ
src/csi.ts 92.36% <94.44%> (+0.15%) ⬆️
src/tbi.ts 96.82% <96.77%> (-1.15%) ⬇️
src/util.ts 76.19% <100.00%> (+35.01%) ⬆️
src/chunk.ts 72.22% <0.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962e5b4...91b54c7. Read the comment docs.

@cmdcolin
Copy link
Contributor Author

Fixes #118

@rbuels
Copy link
Contributor

rbuels commented Dec 10, 2020

Any reason this is still draft?

@cmdcolin cmdcolin marked this pull request as ready for review December 10, 2020 21:06
@cmdcolin
Copy link
Contributor Author

I make everything draft by default currently

@cmdcolin
Copy link
Contributor Author

It is probably good to go here though

@cmdcolin cmdcolin merged commit 7dde1d5 into master Dec 10, 2020
@rbuels rbuels deleted the bam_version_index branch December 11, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants