Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of size() #99

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Remove usage of size() #99

merged 1 commit into from
Apr 28, 2020

Conversation

cmdcolin
Copy link
Contributor

The usage of size() in this library to guard against possibly over-reading the end of the file seems like a unnecessary precaution that results users requiring a more complex CORS config e.g. exposing content-range which seems somewhat atypical for CORS configs

I think that size() is precautionary and anything that fetched past the end of the file would imply a corrupt index so our code wouldn't really help the fact that the index is corrupt and therefore, can probably be removed

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #99 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   90.79%   90.74%   -0.06%     
==========================================
  Files           7        7              
  Lines         554      551       -3     
  Branches      150      149       -1     
==========================================
- Hits          503      500       -3     
  Misses         51       51              
Impacted Files Coverage Δ
src/tabixIndexedFile.ts 91.47% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af0c30...f6ef75b. Read the comment docs.

@cmdcolin cmdcolin merged commit 5a3e958 into master Apr 28, 2020
@cmdcolin cmdcolin deleted the remove_size branch April 30, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant