Support dds/ prefix for dds images. #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported the following commits from https://gitlab.com/xonotic/netradiant: (cherry picked from commit 6998d7a4b8491415a8d01569c58a0e04e5f86dfa) (cherry picked from commit 2baabe14fbecf9fe43f4ef0ddab4cbdc7b20e015) (cherry picked from commit c47f9a96ca72b3dc5ffeb1a196e0917a88f27885) Co-authored-by: Clyybber <darkmine956@gmail.com>
Ported the following commits from https://gitlab.com/xonotic/netradiant: (cherry picked from commit 77738387d6d0b1d59daf4c456941fdaf322b7b67) (cherry picked from commit 90f54911568e6f9b47a5e7561665d92d36eaccfd) (cherry picked from commit 6c135d59c0b59e4a17ba6988ae0b2d39c2165ff5) Co-authored-by: Clyybber <darkmine956@gmail.com>
|
I'm very sorry, but i highly dislike idea of adding this hack, as it's intrusive and adding ambiguity. I think better place for this is engine, which can additionally lookup .dds in regular path w/o dds/ |
|
Fair enough, I'd prefer if the implementation was a bit cleaner/more self contained too. |
Garux
force-pushed
the
master
branch
3 times, most recently
from
9f211cb
to
f6972d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over the changes outlined in https://netradiant.gitlab.io/post/2021-11-08-dds-prefix/.