Feat: Added Delete for me support on behalf of a user #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2025 03:31
daksh-r
changed the title
daksh-r
requested review from
10printhello,
slavabobik and
totalimmersion
as code owners
daksh-r
commented
Sep 1, 2025
Comment on lines
+137
to
+140
| async def delete( | ||
| self, relative_url: str, params: Dict = None, data: Any = None | ||
| ) -> StreamResponse: | ||
| return await self._make_request(self.session.delete, relative_url, params, data) |
Contributor
Author
There was a problem hiding this comment.
Added to allow delete(relative_url, params=None, data=None) in async client to match sync behavior.
daksh-r
commented
Sep 1, 2025
Comment on lines
+101
to
+103
| if method.__name__ in ["post", "put", "patch"] or ( | ||
| method.__name__ == "delete" and data | ||
| ): |
Contributor
Author
There was a problem hiding this comment.
Added to serialize DELETE body only when data is provided; keeps existing DELETEs unchanged.
totalimmersion
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request