Skip to content

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Sep 30, 2025

🔗 Issue Links

https://linear.app/stream/issue/IOS-1164

🎯 Goal

Allow overriding the action when tapping the image of a link attachment view.

🧪 Manual Testing Notes

N/A. Requires changing DefaultViewFactory to test it (Which I did).

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner September 30, 2025 15:35
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 30, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.43 MB 9.48 MB +49 KB 🟢

Copy link

Public Interface

 public struct LinkAttachmentView: View  
-   public init(linkAttachment: ChatMessageLinkAttachment,width: CGFloat,isFirst: Bool)
+   public init(linkAttachment: ChatMessageLinkAttachment,width: CGFloat,isFirst: Bool,onImageTap: ((ChatMessageLinkAttachment) -> Void)? = nil)

 public struct LinkAttachmentContainer: View  
-   public init(factory: Factory,message: ChatMessage,width: CGFloat,isFirst: Bool,scrolledId: Binding<String?>)
+   public init(factory: Factory,message: ChatMessage,width: CGFloat,isFirst: Bool,scrolledId: Binding<String?>,onImageTap: ((ChatMessageLinkAttachment) -> Void)? = nil)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuno-vieira nuno-vieira merged commit f50d1a4 into develop Oct 1, 2025
3 of 5 checks passed
@nuno-vieira nuno-vieira deleted the add/allow-overriding-tap-image-link branch October 1, 2025 13:25
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants