Skip to content

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Oct 6, 2025

🔗 Issue Links

Resolves: IOS-1172

🎯 Goal

  • Allow configuring add member button colors and fix rendering on iOS 26

📝 Summary

  • Add ColorPalette.navigationBarGlyph for configuring the glyph color of the add members button
  • Use ColorPalette.navigationBarTint for background of the add members button
  • Disable glass effect for add members button

🛠 Implementation

🎨 Showcase

iOS 26

Before After
ios26_before ios26_after

iOS 18

Before After
ios18_before ios18_after

🧪 Manual Testing Notes

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus requested a review from a team as a code owner October 6, 2025 13:42
@laevandus laevandus added 🐞 Bug ✅ Feature An issue or PR related to a feature labels Oct 6, 2025
@laevandus laevandus marked this pull request as draft October 6, 2025 13:46
@laevandus laevandus force-pushed the add-members-button-colors branch 2 times, most recently from 2eb3fc0 to 770ff2e Compare October 6, 2025 13:58
@laevandus laevandus force-pushed the add-members-button-colors branch from 770ff2e to be256a0 Compare October 6, 2025 14:01
@laevandus laevandus marked this pull request as ready for review October 6, 2025 14:01
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Copy link

github-actions bot commented Oct 6, 2025

Public Interface

 public struct ColorPalette  
-   public var navigationBarTitle: UIColor
+   public var navigationBarGlyph: UIColor
-   public var navigationBarSubtitle: UIColor
+   public var navigationBarTitle: UIColor
-   public var navigationBarTintColor: Color
+   public var navigationBarSubtitle: UIColor
-   public var navigationBarBackground: UIColor?
+   public var navigationBarTintColor: Color
-   public var bannerBackgroundColor: UIColor
+   public var navigationBarBackground: UIColor?
-   
+   public var bannerBackgroundColor: UIColor
- 
+   
-   public init()
+ 
+   public init()

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 6, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.5 MB 9.5 MB +3 KB 🟢

@laevandus laevandus enabled auto-merge (squash) October 7, 2025 04:09
@laevandus laevandus disabled auto-merge October 7, 2025 04:10
@laevandus laevandus enabled auto-merge (squash) October 7, 2025 04:14
Copy link

sonarqubecloud bot commented Oct 7, 2025

@laevandus laevandus merged commit c7547c2 into develop Oct 7, 2025
11 checks passed
@laevandus laevandus deleted the add-members-button-colors branch October 7, 2025 06:27
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 Bug ✅ Feature An issue or PR related to a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants