Make Logger thread-safe #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,147 @@ | |||
| // | |||
| // Logger_Tests.swift | |||
There was a problem hiding this comment.
Can you update the header here?
There was a problem hiding this comment.
Woah, linter also did not catch it. Added a template as well.
martinmitrevski
approved these changes
Sep 24, 2025
ipavlidakis
reviewed
Sep 24, 2025
| var destinationTypes: [LogDestination.Type] = LogConfig.defaultDestinations | ||
| } | ||
|
|
||
| static let configuration = AllocatedUnfairLock<Configuration>(Configuration()) |
| } | ||
|
|
||
| public enum LogConfig { | ||
| struct Configuration { |
There was a problem hiding this comment.
Having Configuration inside LogConfig sounds confusing. Shall we make it State?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-1160
🎯 Goal
Make Logger thread-safe because it sometimes crashes tests in Feeds
📝 Summary
🛠 Implementation
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo