Add StateUpdateEvent
and relative code, and migrate ActivityCommentList
to consuming it
#83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We're going to put a layer between WS events/backend responses and actual state updates. This layer is represented by
StateUpdateEvent
. So the logic will be:StateUpdateEvent
and forward itStateUpdateEvent
s and forward itStateUpdateEvent
s, so they will react to both scenarios aboveWhy?
Because at the moment, if we're not receiving socket events, the various entity aren't propagating updates on operations executed by the SDK. For example, let's say we are not watching a feed and we execute
activity.addCommentReaction
. Then, only thatActivity
instance's state will be updated and nothing else (e.g. we could have otherActivity
instances containing the same comment, or aCommentList
instance, etc).So the changes that start with this PR will address these cases.
Ref iOS PR: GetStream/stream-feeds-swift#15
Implementation
StateUpdateEvent
& the first few childrenStateUpdateEventListener
to propagate/receiveStateUpdateEvent
sStreamSubscriptionManager<StateUpdateEventListener>
together/in place of the WS-related oneTesting
Everything should work as before + if we have multiple
ActivityCommentList
instances watching the same comments, and we do operations throughActivity
affecting those comments, they should be reflected in each instance.Checklist