Migrate CommentList & BookmarkList to consuming state update events
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CommentList and BookmarkList components to use the new StateUpdateEvent system instead of the previous WSEvent approach. This change improves type safety and provides a more structured event handling mechanism.
- Refactors event handlers to consume
StateUpdateEventinstead ofWSEvent - Updates subscription managers to use
StateUpdateEventListenerinstead ofFeedsEventListener - Adds new event types for bookmark and bookmark folder operations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
StateUpdateEvent.kt |
Adds new event types for bookmark operations and conversion methods |
CommentListEventHandler.kt |
Migrates from WSEvent to StateUpdateEvent handling |
BookmarkListEventHandler.kt |
Updates to use StateUpdateEvent with improved type safety |
CommentListImpl.kt |
Changes subscription manager type reference |
BookmarkListImpl.kt |
Updates subscription manager type reference |
FeedsClientImpl.kt |
Switches to using state events subscription manager |
| Test files | Updates test setup to use new event types and removes unused imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...in/io/getstream/feeds/android/client/internal/state/event/handler/CommentListEventHandler.kt
Show resolved
Hide resolved
SDK Size Comparison 📏
|
aleksandar-apostolov
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Continuing from #83, we migrate the
CommentList&BookmarkListImplementation
Change handler from
WSEventtoStateUpdateEventTesting
Nothing should change externally, as here we're just consuming WS events using different types from before, but not emitting events from new places (yet).
Checklist