Migrate FeedList, ActivityReactionList, CommentReactionList, BookmarkFolderList to consuming state update events
#88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates event handlers for FeedList, ActivityReactionList, CommentReactionList, and BookmarkFolderList from consuming WebSocket events (WSEvent) to consuming state update events (StateUpdateEvent).
- Refactors event handlers to use
StateUpdateEventinstead ofWSEventfor better type safety and consistency - Updates subscription managers to use
StateUpdateEventListenerinterface instead ofFeedsEventListener - Consolidates test structure using a new
BaseEventHandlerTestclass for parameterized testing
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
StateUpdateEvent.kt |
Adds new event types and conversion logic for activity reactions and feed operations |
*EventHandler.kt files |
Migrates handlers from WSEvent to StateUpdateEvent consumption |
*Impl.kt files |
Updates subscription manager types from FeedsEventListener to StateUpdateEventListener |
FeedsClientImpl.kt |
Updates dependency injection to use state events subscription manager |
| Test files | Refactors tests to use parameterized approach with base test class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...t/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt
Show resolved
Hide resolved
SDK Size Comparison 📏
|
VelikovPetar
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Same as #87, but for
FeedList,ActivityReactionList,CommentReactionList,BookmarkFolderListImplementation
Change handler from
WSEventtoStateUpdateEventTesting
Nothing should change externally, as here we're just consuming WS events using different types from before, but not emitting events from new places (yet).
Checklist