-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate the remaining XyzList
controllers
#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the remaining controller event handlers from the legacy WebSocket event system (WSEvent
) to the new state update event system (StateUpdateEvent
). The migration updates FollowList
, CommentReplyList
, MemberList
, PollList
, and PollVoteList
controllers to use the modern event handling pattern.
- Migrates 5 list controllers to use
StateUpdateEvent
instead ofWSEvent
- Updates test files to use parameterized testing patterns where applicable
- Fixes subscription manager references to use the correct event listener types
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
Event Handlers | Migrated 5 event handlers from WSEvent to StateUpdateEvent system |
Test Files | Updated test files to use new event types and parameterized test patterns |
Implementation Classes | Updated subscription manager types to use StateUpdateEventListener |
StateUpdateEvent.kt | Added new event types for the migrated controllers |
FeedsClientImpl.kt | Fixed subscription manager references to use correct event types |
ActivityImpl.kt | Cleaned up redundant subscription manager parameter |
FeedImpl.kt | Updated to use both old and new subscription managers during transition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SDK Size Comparison 📏
|
2e30867
to
071fa44
Compare
XyzList
controllersXyzList
controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...t/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt
Show resolved
Hide resolved
...t/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt
Show resolved
Hide resolved
39bec82
to
eae2836
Compare
Goal
Same as #87, but for
FollowList
,CommentReplyList
,MemberList
,PollList
,PollVoteList
,ActivityList
. With this, the only things left to migrate areActivity
&Feed
.Implementation
Change handler from
WSEvent
toStateUpdateEvent
Testing
Nothing should change externally, as here we're just consuming WS events using different types from before, but not emitting events from new places (yet).
Checklist