Skip to content

Conversation

gpunto
Copy link
Contributor

@gpunto gpunto commented Sep 30, 2025

Goal

Same as #87, but for FollowList, CommentReplyList, MemberList, PollList, PollVoteList, ActivityList. With this, the only things left to migrate are Activity & Feed.

Implementation

Change handler from WSEvent to StateUpdateEvent

Testing

Nothing should change externally, as here we're just consuming WS events using different types from before, but not emitting events from new places (yet).

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto requested a review from Copilot September 30, 2025 09:04
Copy link
Contributor

github-actions bot commented Sep 30, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto added the pr:internal Internal changes / housekeeping label Sep 30, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the remaining controller event handlers from the legacy WebSocket event system (WSEvent) to the new state update event system (StateUpdateEvent). The migration updates FollowList, CommentReplyList, MemberList, PollList, and PollVoteList controllers to use the modern event handling pattern.

  • Migrates 5 list controllers to use StateUpdateEvent instead of WSEvent
  • Updates test files to use parameterized testing patterns where applicable
  • Fixes subscription manager references to use the correct event listener types

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Event Handlers Migrated 5 event handlers from WSEvent to StateUpdateEvent system
Test Files Updated test files to use new event types and parameterized test patterns
Implementation Classes Updated subscription manager types to use StateUpdateEventListener
StateUpdateEvent.kt Added new event types for the migrated controllers
FeedsClientImpl.kt Fixed subscription manager references to use correct event types
ActivityImpl.kt Cleaned up redundant subscription manager parameter
FeedImpl.kt Updated to use both old and new subscription managers during transition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Sep 30, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.47 MB 2.47 MB 0.00 MB 🟢

@gpunto gpunto changed the title Migrate remaining XyzList controllers Migrate the remaining XyzList controllers Sep 30, 2025
@gpunto gpunto requested a review from Copilot September 30, 2025 09:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gpunto gpunto force-pushed the state-events-4 branch 2 times, most recently from 39bec82 to eae2836 Compare September 30, 2025 09:35
@gpunto gpunto marked this pull request as ready for review September 30, 2025 10:18
@VelikovPetar VelikovPetar merged commit 2e7c302 into develop Oct 1, 2025
6 checks passed
@VelikovPetar VelikovPetar deleted the state-events-4 branch October 1, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:internal Internal changes / housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants