Fix: Inventory opening issues related to virtual chest queuing

Author: onebeastchris

core/src/main/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockContainerCloseTranslator.java

@@ -61,6 +61,7 @@ public void translate(GeyserSession session, ContainerClosePacket packet) {
             } else if (holder.bedrockId() == session.getPendingOrCurrentBedrockInventoryId()) {
                 // If virtual inventories are opened too quickly, they can be occasionally rejected
                 // We just try and queue a new one.
+                holder.inventory().setDisplayed(false);
                 // Before making another attempt to re-open, let's make sure we actually need this inventory open.
                 if (holder.containerOpenAttempts() < 7) {
                     holder.incrementContainerOpenAttempts();

core/src/main/java/org/geysermc/geyser/util/InventoryUtils.java

@@ -118,14 +118,20 @@ public static void openInventory(InventoryHolder<?> holder) {
      */
     public static void openPendingInventory(GeyserSession session) {
         InventoryHolder<?> holder = session.getInventoryHolder();
-        if (holder == null || !holder.pending()) {
+        if (holder == null) {
             session.setPendingOrCurrentBedrockInventoryId(-1);
             GeyserImpl.getInstance().getLogger().debug(session, "No pending inventory, not opening an inventory! Current inventory: %s", debugInventory(holder));
             return;
         }
 
         // Current inventory isn't null! Let's see if we need to open it.
-        if (holder.inventory().getBedrockId() == session.getPendingOrCurrentBedrockInventoryId()) {
+        if (holder.bedrockId() == session.getPendingOrCurrentBedrockInventoryId()) {
+            // Don't re-open an inventory that is already open
+            if (!holder.pending() && holder.inventory().isDisplayed()) {
+                GeyserImpl.getInstance().getLogger().debug("Container with id %s is not pending and already displayed!".formatted(holder.bedrockId()));
+                return;
+            }
+
             GeyserImpl.getInstance().getLogger().debug(session, "Attempting to open currently delayed inventory with matching bedrock id! " + holder.bedrockId());
             openAndUpdateInventory(holder);
             return;