Catch slot IDs under 0 when checking inventory bounds in set slot packet (#5579)

* Catch slot IDs under 0 when checking inventory bounds in set slot packet and improve log messages

* This should probably be an above or equals check

Author: eclipseisoffline

core/src/main/java/org/geysermc/geyser/inventory/Inventory.java

@@ -139,8 +139,8 @@ public GeyserItemStack getItem(int slot) {
     public abstract int getOffsetForHotbar(@Range(from = 0, to = 8) int slot);
 
     public void setItem(int slot, @NonNull GeyserItemStack newItem, GeyserSession session) {
-        if (slot > this.size) {
-            session.getGeyser().getLogger().debug("Tried to set an item out of bounds! " + this);
+        if (slot < 0 || slot >= this.size) {
+            session.getGeyser().getLogger().debug("Tried to set an item out of bounds (slot was " + slot + ")! " + this);
             return;
         }
         GeyserItemStack oldItem = items[slot];

core/src/main/java/org/geysermc/geyser/translator/protocol/java/inventory/JavaContainerSetSlotTranslator.java

@@ -70,10 +70,10 @@ public void translate(GeyserSession session, ClientboundContainerSetSlotPacket p
 
         Inventory inventory = holder.inventory();
         int slot = packet.getSlot();
-        if (slot >= inventory.getSize()) {
+        if (slot < 0 || slot >= inventory.getSize()) {
             GeyserLogger logger = session.getGeyser().getLogger();
-            logger.warning("ClientboundContainerSetSlotPacket sent to " + session.bedrockUsername()
-                    + " that exceeds inventory size!");
+            logger.warning("Slot of ClientboundContainerSetSlotPacket sent to " + session.bedrockUsername()
+                    + " is out of bounds! Was: " + slot + " for container: " + packet.getContainerId());
             if (logger.isDebug()) {
                 logger.debug(packet.toString());
                 logger.debug(inventory.toString());