Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-2497] Allow to connect multiple external mlworkers #1740

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Jan 17, 2024

See also https://github.com/Giskard-AI/giskard-hub/pull/399

TODO:

  • reworking the cli worker (restart, stop command)
  •  re word the error message in cli worker

@Hartorn Hartorn self-assigned this Jan 17, 2024
Copy link

linear bot commented Jan 17, 2024

@Hartorn Hartorn changed the title Feature/gsk 2497 allow to connect multiple external mlworkers [GSK-2497] Allow to connect multiple external mlworkers Jan 17, 2024
@Hartorn Hartorn force-pushed the feature/gsk-2497-allow-to-connect-multiple-external-mlworkers branch from 12f3623 to 7950cbf Compare January 18, 2024 14:19
@Hartorn Hartorn marked this pull request as ready for review January 19, 2024 13:45
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

18.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

def get_log_path():
return run_dir / "ml-worker.log"


def tail(filename, n=100):
"""Return the last n lines of a file"""
return collections.deque(open(filename), n)
with Path(filename).open("r", encoding="utf-8") as fp:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice capture!

@Hartorn Hartorn merged commit 1a90df7 into multi-ml-worker Jan 29, 2024
28 of 30 checks passed
@Hartorn Hartorn deleted the feature/gsk-2497-allow-to-connect-multiple-external-mlworkers branch January 29, 2024 09:00
andreybavt added a commit that referenced this pull request Apr 7, 2024
[GSK-2497] Allow to connect multiple external mlworkers (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants