-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-2497] Allow to connect multiple external mlworkers #1740
Merged
Hartorn
merged 8 commits into
multi-ml-worker
from
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers
Jan 29, 2024
Merged
[GSK-2497] Allow to connect multiple external mlworkers #1740
Hartorn
merged 8 commits into
multi-ml-worker
from
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartorn
changed the title
Feature/gsk 2497 allow to connect multiple external mlworkers
[GSK-2497] Allow to connect multiple external mlworkers
Jan 17, 2024
Hartorn
force-pushed
the
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers
branch
from
January 18, 2024 14:19
12f3623
to
7950cbf
Compare
Quality Gate failedFailed conditions 18.9% Coverage on New Code (required ≥ 70%) |
Inokinoki
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
def get_log_path(): | ||
return run_dir / "ml-worker.log" | ||
|
||
|
||
def tail(filename, n=100): | ||
"""Return the last n lines of a file""" | ||
return collections.deque(open(filename), n) | ||
with Path(filename).open("r", encoding="utf-8") as fp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice capture!
Hartorn
deleted the
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers
branch
January 29, 2024 09:00
andreybavt
added a commit
that referenced
this pull request
Apr 7, 2024
[GSK-2497] Allow to connect multiple external mlworkers (#1740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://github.com/Giskard-AI/giskard-hub/pull/399
TODO: