Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-2497] Allow to connect multiple external mlworkers (#1740) #1771

Merged
merged 62 commits into from
Apr 7, 2024

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Jan 29, 2024

Main branch for multiple ml workers (not yet to be merged)

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

* WIP

* Removing notion of internal and external

* Fix raised error in CLI

* Fixing lint + fixing tests

* Fix cli for worker

* Fix linting

* Fixing communications tests
@Hartorn Hartorn self-assigned this Jan 29, 2024
Copy link

linear bot commented Jan 29, 2024

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 5, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Mar 5, 2024
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
Inokinoki and others added 11 commits April 2, 2024 17:20
…l-telemetry

[GSK-3419] Add mixpanel telemetry to new client methods
…[hub, llm] (#1876)

* Add `exact_deps` parameter to allow extract deps with extras (always on for giskard)

* Add excluded libs for `pip` and `setuptools` (user-definable)

* Fix var name for `requested_dependencies`

---------

Co-authored-by: Kevin Messiaen <114553769+kevinmessiaen@users.noreply.github.com>
…kard-only-on-google-colab-and-the-other-cloud

[GSK-3442] Install giskard only on google colab
@andreybavt andreybavt marked this pull request as ready for review April 5, 2024 14:43
…igration-for-existing-projects

[GSK-2877] Update doc about ML worker to adapt kernel and multi-ML worker
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@andreybavt andreybavt merged commit 1f8da90 into main Apr 7, 2024
15 of 16 checks passed
@andreybavt andreybavt deleted the multi-ml-worker branch April 7, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants