-
Notifications
You must be signed in to change notification settings - Fork 16
Closed
Labels
status:confirmedThis issue has been reviewed and confirmedThis issue has been reviewed and confirmedtype:bugSomething isn't workingSomething isn't working
Description
Commit 9642af5 added imports for libraries that aren't actually dependencies for pygitguardian
. Specifically, these imports:
import click |
py-gitguardian/tests/test_utils.py
Line 5 in 183784d
import click |
import marshmallow_dataclass |
It seems reasonable that marshmallow-dataclass
should be added as a dependency for an API client, but I think making click
a dependency would limit the usefulness. I suspect removing click
will require modifications to ggshield
.
Metadata
Metadata
Assignees
Labels
status:confirmedThis issue has been reviewed and confirmedThis issue has been reviewed and confirmedtype:bugSomething isn't workingSomething isn't working