-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(treemap): shade background for unused bytes #12486
Conversation
I think it's too busy... prefer this: also concerned how user would know which shade is unsued vs used also concerned that we'd have two different ways to visualizing coverage. would like to see: only highlighed nodes (the most egregious unused nodes) getting a special treatment; and that treatment being the same thing used in the coverage table column |
I agree, couldn't tell which shade represents "used" at first glance. |
yes. it's def busy.
yeah the thing i don't like about that is the arbitrary thresholds. I think there are likely still modules of interest that are slightly below those numbers. it's hard to hit a binary threshold right so i want to make it a continuous thing.
yeah totally fair. i'm gonna try a candystripe shading to see if it helps. |
+1 to the new changes Paul demoed in today's meeting. |
@@ -201,6 +208,27 @@ header { | |||
outline: 2px solid black; | |||
} | |||
|
|||
.webtreemap-node::before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic? magic. ok.
Co-authored-by: Connor Clark <cjamcl@google.com>
f92764b
to
14acb07
Compare
proposing this alternative UX for 'Unused Bytes' mode.
https://lighthouse-git-treemap-unusedhue-googlechrome.vercel.app/gh-pages/treemap/?debug and click 'unused bytes'
compared to
https://lighthouse-git-master-googlechrome.vercel.app/gh-pages/treemap/?debug