Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(treemap): fix node coverage shading #12603

Merged
merged 1 commit into from
Jun 2, 2021
Merged

misc(treemap): fix node coverage shading #12603

merged 1 commit into from
Jun 2, 2021

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jun 2, 2021

We added this in #12486 but turns out the logic was inverted.

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner June 2, 2021 17:38
@connorjclark connorjclark requested review from adamraine and removed request for a team June 2, 2021 17:38
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
@connorjclark connorjclark merged commit dbe7884 into master Jun 2, 2021
@connorjclark connorjclark deleted the tm-fix-shade branch June 2, 2021 18:24
@brendankenny
Copy link
Member

with 8.0 out and turning our attention to polishing, is there some room for adding tests for this kind of thing? It's hard to catch coverage problems visually from debug.json (e.g. I assume this fixes bullet #3 in #11254 (comment) but the problem wasn't obvious) but would be relatively easy to test programmatically (e.g. 10% unused bytes and getComputedStyle(el, '::before').width is 10% of el's width)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants