Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

feat: create default VPC network if it does not exist already #1052

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

lvaylet
Copy link

@lvaylet lvaylet commented Oct 2, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Your change follows guidelines in the Contributor guide
  • Communicate test infrastructure changes, i.e. API enablement, secrets
  • Appropriate docs were updated (if necessary)

🛠️ Fixes #1043

@lvaylet lvaylet requested a review from a team as a code owner October 2, 2023 09:26
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@lvaylet
Copy link
Author

lvaylet commented Oct 9, 2023

Hi @minherz, any chance you could review this PR for milestone/0.10?

@arbrown arbrown merged commit ee46c8f into GoogleCloudPlatform:milestone/0.10 Oct 19, 2023
5 checks passed
@lvaylet lvaylet deleted the patch-3 branch October 20, 2023 08:01
@minherz
Copy link
Contributor

minherz commented Oct 30, 2023

updated: This change is rolled back. The rationale behind the rollback includes:

  • COB deprecates support for provisioning demo applications in order to focus on demonstration of the observability features of Cloud Ops services. The expectations for the default VPC configuration exists in the provided project is reasonable and works like this in majority of deployments.
  • Provisioning a new VPC on the user's project may have unexpected side-effects on other workflows running in the project
  • The implemented provisioning lacks dependencies which results in unstable deployment and multiple failures due to unresolved dependencies.

@lvaylet
Copy link
Author

lvaylet commented Oct 31, 2023

Thanks for the update. I just tested this approach in a clean project with no default VPC. It does not work indeed. I was pretty sure I had tested it prior to submitting the PR. I probably did so in a project that already had a default VPC.

minherz pushed a commit that referenced this pull request Nov 25, 2023
* feat: create `default` network if it does not exist already

* fix: comments must end with a period
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants