Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jan 20, 2021

The next test will receive a URL, and we do not have reasonably easy
ways to parse a URL. None that can be put in an example anyway: we
could use a regexp, but they are brutally complicated.

The next test will receive a URL, and we do not have reasonably easy
ways to parse a URL.  None that can be put in an example anyway: we
could use a regexp, but they are brutally complicated.
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #191 (7d07d7f) into main (8cb15c4) will decrease coverage by 0.12%.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   97.54%   97.42%   -0.13%     
==========================================
  Files          65       65              
  Lines        1551     1556       +5     
==========================================
+ Hits         1513     1516       +3     
- Misses         38       40       +2     
Impacted Files Coverage Δ
...xamples/site/testing_http/http_integration_test.cc 87.03% <82.05%> (-2.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb15c4...5162df4. Read the comment docs.

@coryan coryan marked this pull request as ready for review January 20, 2021 15:50
@coryan coryan requested a review from a team as a code owner January 20, 2021 15:50
@coryan coryan merged commit 4a1502c into GoogleCloudPlatform:main Jan 21, 2021
@coryan coryan deleted the refactor-http-testing-use-curl branch January 21, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants