fix: several minor fixes #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a couple of maven plugins's scope to provided as recommended by Maven. Fixed GoogleCloudPlatform#117: during first deploy unless the allowUnauthenticated property was set to true, the gcloud command was waiting on a prompt that was not visible and could not be interacted with. This change removes the allowUnauthenticated property's default value and relies on gcloud's behavior which will default this value to false if prompting is turned off with '--quiet'. If the allowUnauthenticated is explicitly set, it will correctly append the --[no-]allow-unauthenticated flag to the command. If the gcloud command fails, the plugin will not report a successful build.
dixuswe
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a couple of maven plugins's scope to provided as recommended by Maven.
Fixed #117: during first deploy unless the allowUnauthenticated property was set to true, the gcloud command was waiting on a prompt that was not visible and could not be interacted with. This change removes the allowUnauthenticated property's default value and relies on gcloud's behavior which will default this value to false if prompting is turned off with '--quiet'. If the allowUnauthenticated is explicitly set, it will correctly append the --[no-]allow-unauthenticated flag to the command.
If the gcloud command fails, the plugin will not report a successful build.