Skip to content

Conversation

@glasnt
Copy link
Collaborator

@glasnt glasnt commented Dec 10, 2023

fixes #186

Unsure how it needed tidy, and why renovate-bot didn't automatically do this.

@glasnt glasnt requested review from a team and donmccasland as code owners December 10, 2023 23:27
@glasnt
Copy link
Collaborator Author

glasnt commented Dec 11, 2023

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Dec 11, 2023

fixes #186

Unsure how it needed tidy, and why renovate-bot didn't automatically do this.

Yeah, not sure about #186, but looking to see if there is a way to combine the dev-tools 1.18 and GO 1.21 PRs.

@apeabody apeabody closed this Dec 11, 2023
@apeabody apeabody reopened this Dec 11, 2023
@apeabody apeabody enabled auto-merge (squash) December 11, 2023 01:12
@apeabody
Copy link
Contributor

fixes #186
Unsure how it needed tidy, and why renovate-bot didn't automatically do this.

Yeah, not sure about #186, but looking to see if there is a way to combine the dev-tools 1.18 and GO 1.21 PRs.

@glasnt - I found what is happening. The INT CloudBuild https://github.com/GoogleCloudPlatform/terraform-dynamic-python-webapp/blob/main/build/int.cloudbuild.yaml#L69 is using dev-tools 1 rather than pinned to a minor version (e.g. 1.17). I'd recommend switching to 1.18 in https://github.com/GoogleCloudPlatform/terraform-dynamic-python-webapp/pull/185/files so they track together.

@apeabody apeabody merged commit 80d2b76 into main Dec 11, 2023
@apeabody apeabody deleted the gomod branch December 11, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing periodic

2 participants