fix: prevent website not found errors after firebase deploy completes #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
changed the title
glasnt
force-pushed
the
purge-frontend-cache-on-deploy
branch
from
772c2dd to
b5731d0
Compare
…udPlatform/terraform-dynamic-python-webapp into purge-frontend-cache-on-deploy
Collaborator
|
I updated the code to correctly validate that the URL should error (the |
Contributor
Author
|
I refactored the code to have an |
glasnt
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #64
This change is expected to restore frontend UI loading after firebase deploy completes. It does not address the gap between terraform apply and firebase deploy.