Add standardized common SortIcon component #13987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
maxiadlovskii
changed the title
10 tasks
linuspahl
reviewed
Nov 22, 2022
| cursor: pointer; | ||
| position: relative; | ||
| color: ${theme.colors.gray[70]}; | ||
| &.active { |
There was a problem hiding this comment.
instead of adding a class we can just provide the state as a prop ($active) for the component.
There was a problem hiding this comment.
I use this class in the tests. with a prop I wouldn't be able to pick active item
| if (activeDirection === descId) return 'arrow-down-wide-short'; | ||
|
|
||
| return 'arrow-down-wide-short'; | ||
| }, [activeDirection, ascId, descId]); |
There was a problem hiding this comment.
It probably costs more to use useMemo here, compared with not memorising the result.
There was a problem hiding this comment.
Maybe... I will change it. But descId in condition. We might need it for the future
dennisoelkers
changed the title
linuspahl
approved these changes
Nov 28, 2022
bernd
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Create sort Icon * Allow defining custom direction ids for common `SortIcon`. * Create sort Icon * Add sort Icon to message table and data table * Fix data table header test * Add license * Add tests * Add changelog * Refactoring * fix tsc errors Co-authored-by: Linus Pahl <linus@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Sort Icon component. This component can be used in different application parts to ensure that we have the same standard.
Motivation and Context
fix: #13982
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: