This repository was archived by the owner on Jan 9, 2024. It is now read-only.
change self.get to getattr in rediscluster/client.py _get_single_item #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactoring (0.2.0)
Release 1.2.0
…anted log messages
PUBSUB commands added to redis-py in 3f4ac6, which according to Redis docs (https://redis.io/commands/pubsub, https://redis.io/topics/pubsub) can be sent to any node
Added parsing callbacks for all three `PUBSUB` sub-commands, which give these commands the same behaviour as in single-node Redis & `redis-py`. **Note** that the switches on each method to *not* aggregate responses into one appear to not be bubbling through to the callback.
…BSUB commands ``**kwargs`` is not bubbled through to all result callbacks to enable the toggle to reach the PUBSUB parsing methods in `utils.py`. This adds `**kwargs` to the `StrictRedisCluster._merge_result` method's signature.
Now tests on ordered list
* Using `string_keys_to_dict` for all RESULT_CALLBACKS * Simplified `subscribe` calls in test cases to remove unnecessary variable declarations * Remove change to `_random_good_hashslot_key` which was not related to PR * Add `set_result_callback(command, callback)` to match Redis-Py feature `set_response_callback` * Skipping redis-py versions below `2.10.6` for `PUBSUB` tests * Add docstring to `TestPubSubPubSubSubcommands` class * Adding docs on pubsub subcommands, and to release notes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change self.get to getattr in rediscluster/client.py _get_single_item