Updates to how cosmology is handled within hera_pspec
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
info between objects and modules
and added tests for updates
nkern
force-pushed
the
cosmo_handling_update
branch
from
4090d67 to
72d32ab
Compare
philbull
approved these changes
May 1, 2018
hera_pspec/noise.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| Tsys : float, System temperature in Kelvin |
There was a problem hiding this comment.
scalar parameter isn't documented
hera_pspec/pspecdata.py
Outdated
| if self.primary_beam is None: | ||
| pspec_units = "({})^2 Hz [beam normalization not specified]".format(self.dsets[0].vis_units) | ||
| norm_units = "Hz str [beam normalization not specified]".format(self.dsets[0].vis_units) |
There was a problem hiding this comment.
This has no format placeholder, e.g. {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how the passing of cosmology info is done between the various objects (i.e. all of them) in
hera_pspec. This is done to be much clearer to the user, and be explicit about when and how cosmologies are adopted how they can be overwritten.In particular, if a cosmology is adopted to create a
UVPSpecobject, if it is overwritten, then the power spectrum scalar is re-calculated and the power spectra are appropriately re-normalized.