Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to PTR-RBL #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changes to PTR-RBL #57

wants to merge 3 commits into from

Conversation

RohitPrashant
Copy link

made the following changes to PTR-RBL:
%% Pg. 27, PTR-RBL
b= dec2bin(2^4-1:-1:0)-'0';
b1=b(:,1);b2=b(:,2);b3=b(:,3);ba=b(:,4);
LHS = min(reshape(-1*b1.*b2.*b3,2,[]));
RHS = min(reshape((ba -b1 + b2 + b3) - b1.*b2 - b1.*b3 + b1,2,[]));
isequal(LHS,RHS)

Added the following code example for PTR-RBL:

%% Pg. 27, PTR-RBL
b= dec2bin(2^4-1:-1:0)-'0';
b1=b(:,1);b2=b(:,2);b3=b(:,3);ba=b(:,4);
LHS = min(reshape(-1*b1.*b2.*b3,2,[]));
RHS = min(reshape((ba -b1 + b2 + b3) - b1.*b2 - b1.*b3 + b1,2,[]));
isequal(LHS,RHS)
@ndattani
Copy link
Member

ndattani commented Apr 23, 2022

Thanks for this contribution @RohitPrashant! Are you also able to verify the quadratization given in the summary section? The z variables are described on page 1 of the book, and due to the ternary variable, the RHS will have a size of 2x2x2x3=24 before the reshape whereas the LHS will have a size of 2x2x2=8. I'm CCing @Jdewbury, the other student that selected a quadratization involving z variables. Also: please be careful not to commit incorrect files, such as the .asv file, in the future. This time it's okay.

@RohitPrashant
Copy link
Author

@ndattani Hi, I just got done with my last final, I will try to verify the quadratization and finish it by tonight. Sorry about the asv file I'm not really sure how that happened but I will make sure it does not happen again.

Added z-variable function equations to this.
@RohitPrashant
Copy link
Author

@ndattani Hi, I have added the verification for the z-variable part, but I was not entirely sure how to work with the qutrit variable.

@ndattani
Copy link
Member

Your LHS1 does not equal RHS1, in fact they don't even have the same size. You'll need to use the kron function a lot more.

@RohitPrashant
Copy link
Author

@ndattani Is it possible to give me more of a hint on how to fix this?

@RohitPrashant RohitPrashant closed this by deleting the head repository Nov 21, 2022
@ndattani
Copy link
Member

@RohitPrashant I'm a bit confused. I've never seen that message before! Basically you permanently deleted your fork of this repository, and that's why the pull request got closed?

@RohitPrashant
Copy link
Author

RohitPrashant commented Nov 22, 2022 via email

@ndattani
Copy link
Member

Hi Rohit,
I see two public repositories on your profile: Truecaller-api (with the last commit being in September) and Parkinsons-detector (with the last commit being yesterday). It looks like not all of your repositories were permanently deleted.

I'm curious how it got deleted? Deleting a repository on GitHub requires a fairly rigorous confirmation check, in which the user is given a stern warning and is asked to type in something precisely with no errors.

As for co-op positions, a more appropriate place to ask would be via email or the HPQC Discord group (in the "General" channel). Please avoid adding any attachments. If you need me to see a file, you can upload it somewhere and send me the link.

@RohitPrashant
Copy link
Author

RohitPrashant commented Nov 23, 2022 via email

@ndattani
Copy link
Member

Hi Rohit,

Adding a new project, and deleting an old one, are two different things. One might argue that these two things are exact opposites of each other! How is it that adding a new project, deleted an old project? I understand that you didn't realize what deleting the repo would do, and I appreciate your apology for the inconvenience, but I just don't understand how adding a new repository can be used as the explanation for why a repository was deleted.

As for the truecaller API project, I seem to be able to see it perfectly as a publicly available repository here: https://github.com/RohitPrashant/Truecaller-api. I see that the last commit was made by you in September. I seem to be able to see everything about that repository.

@ndattani ndattani reopened this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants