Make menus and nav more accessible #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
added
development
tunetheweb
added a commit
that referenced
this pull request
Feb 11, 2020
tunetheweb
added a commit
that referenced
this pull request
Feb 13, 2020
* home page accessibility fixes * Bring home page intro section into index.html * Add fallback background colours * Tidy up responsive sections * Remove fallback colours due to classes on Safari * Add alt text for psuedo content * Add fallback colour incase SVG does not load * Fix typo * Remove alt English text for +/- to avoid translation issues. Fixed properly in #666 * Comment out SVG URL version See #664 (comment) * Move background colour into SVG for consistency * Regenerate base64 banner image
|
Not sure if it's this PR but the layout appears broken on the home page. Could you look into this? |
|
Not seeing this. Can you give more more details (Browser, OS, screensize)? And definitely cleared your cache when you loaded this? |
rviscomi
requested changes
Feb 14, 2020
|
Anything holding up merging this @rviscomi ? Think I answered all your questions but let me know if you still have questions. |
rviscomi
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
ulandlielements (note some have tried to argue against this but general consensus is this is what should be done)navelement on mobile when closedaria-expandedtags and betteraria-labelsA couple of notes on this:
role="menu"as apparently that is wrong for navigation menus which are lists of links and should only be used for true application menus2019.cssto2019.css?v=2as these are breaking changes.