Increase robustness to exotic clang versions #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 2 files. Overall, the semantic diff is 45% smaller than the GitHub diff.
|
HadrienG2
previously approved these changes
Jun 18, 2024
stephenswat
force-pushed
the
fix/exotic_clang_versions
branch
from
c36c130
to
9249367
Compare
As seen in HadrienG2#162, not all clang installations neatly follow the "clang version MAJOR.MINOR" template. This causes crofiler to fail when using, e.g., Debian's provided version of clang. This commit increases the robustness of the version checking by relying on a regular expression which can match a broader range of possible versions. Resolves HadrienG2#162.
auto-merge was automatically disabled
June 18, 2024 11:43
Head branch was pushed to by a user without write access
stephenswat
force-pushed
the
fix/exotic_clang_versions
branch
from
9249367
to
a0cdbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #162, not all clang installations neatly follow the "clang version MAJOR.MINOR" template. This causes crofiler to fail when using, e.g., Debian's provided version of clang. This commit increases the robustness of the version checking by relying on a regular expression which can match a broader range of possible versions.
Resolves #162.