Use CARGO_CFG_TARGET_OS instead of target_os cfg var #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target_os reports the target used to build the build.rs script, while it is needed to check which is the target used to build the crate itself. Partially unbreaks building for linux on a macos host.
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 43% smaller than the GitHub diff.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 65.28% 66.53% +1.25%
==========================================
Files 43 42 -1
Lines 4632 4076 -556
==========================================
- Hits 3024 2712 -312
+ Misses 1608 1364 -244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_os reports the target used to build the build.rs script, while it is needed to check which is the target used to build the crate itself.
Partially unbreaks cross-building, it covers only macos to linux.