Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macro] Build order vs inheritance #11582

Merged
merged 3 commits into from Feb 16, 2024

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Feb 16, 2024

Previous results were:

Main.hx:3: Foo
Main.hx:4: [I2,I1,Foo1]
Main.hx:5: [auto Foo1 (2),auto Foo1 (1),I1,I2,Foo2]
Main.hx:6: [I2,I1,auto Foo1 (1),auto Foo1 (2),Foo3 (1),Foo3 (2)]
Main.hx:7: [auto Foo1 (2),auto Foo1 (1),I1,I2,Foo4]
Main.hx:9: Bar
Main.hx:10: [I1,I2]
Main.hx:11: [I2,I1]
Main.hx:12: [I1,I2]
Main.hx:14: Baz
Main.hx:15: [I2,I3,I1]
Main.hx:16: [I1,I3,I2]
Main.hx:17: [I2,I3,I1]

Which were a bit hard to work with..

@kLabz
Copy link
Contributor Author

kLabz commented Feb 16, 2024

Right, this will break our server tests until they're making use of it 😅

@Simn Simn merged commit 539601b into development Feb 16, 2024
98 checks passed
@kLabz
Copy link
Contributor Author

kLabz commented Feb 18, 2024

I'd add this to 4.3.4 but that's a potentially big change for a patch release..

Would it be ok to add this change under -D haxe-next for 4.3.x? @Simn

@Simn
Copy link
Member

Simn commented Feb 18, 2024

Good idea

kLabz added a commit that referenced this pull request Feb 18, 2024
* [macro] more predictable build macro order with -D haxe-next

* [tests] add macro build order test

* [tests] Run our build macro before utest build macro
@kLabz kLabz mentioned this pull request Feb 18, 2024
19 tasks
kLabz added a commit that referenced this pull request Feb 18, 2024
* [macro] more predictable build macro order with -D haxe-next

* [tests] add macro build order test

* [tests] Run our build macro before utest build macro
@skial skial mentioned this pull request Feb 19, 2024
1 task
@kLabz kLabz deleted the fix/macro-build-order-vs-inheritance branch February 22, 2024 15:34
kLabz added a commit that referenced this pull request Mar 4, 2024
* [macro] more predictable build macro order with -D haxe-next

* [tests] add macro build order test

* [tests] Run our build macro before utest build macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants