Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Int128, Int256, and Int512 + their numeral literal suffixes #11750

Conversation

SomeGuyWhoLovesCoding
Copy link

@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding commented Aug 23, 2024

This pull request implements the logic of the 128-bit, 256-bit, and 512-bit integers. They are of course real integers, but right now you can't create those integers with decimal values directly as opposed to initializing 32-bit integer values.

No tests for those integer classes yet cause that causes me more stress.

@EyeDaleHim
Copy link

I'm not sure if this is the right place to ask for help, the Issues tab might be more sufficient.

@Simn
Copy link
Member

Simn commented Aug 24, 2024

Actually I prefer a PR here because it's easier to reason about the code and see the failing tests, so I think this is a good initiative.

@SomeGuyWhoLovesCoding
Copy link
Author

How come 14 tests failed?

@EyeDaleHim
Copy link

How come 14 tests failed?

That's what the details tab are for, perhaps you can click on them :P

@SomeGuyWhoLovesCoding
Copy link
Author

This is an error from linux build 4.08.1:

   - |   [...]
 126 | }
Type Int64Helper refined from class Int128Helper```

@skial skial mentioned this pull request Aug 24, 2024
1 task
@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding changed the title Upgrade File.getBytes to have starting position and length + Implement Int128 + its numeral literal suffix Implement Int128 + its numeral literal suffix Sep 11, 2024
@SomeGuyWhoLovesCoding
Copy link
Author

Ignore the commits adter the hrr 717 mention. It was an accident and I didn't mean to do so.

@SomeGuyWhoLovesCoding
Copy link
Author

SomeGuyWhoLovesCoding commented Sep 12, 2024

100 commits. Oh boy. I wasted the 15 of them lol

All I did was copy the code over from Int128 like I did with Int128 and replace it with 256 bit integer logic.
@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding changed the title Implement Int128 + its numeral literal suffix Implement Int128 and Int256 + their numeral literal suffixes Nov 9, 2024
SomeGuyWhoLovesCoding and others added 5 commits November 8, 2024 23:38
I don't even want to write Int128 and Int256 test classes cause it's more stress for me.
This was the perfect time to go back to the OCaml hell.
Yeah I'm done
@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding changed the title Implement Int128 and Int256 + their numeral literal suffixes Implement Int128, Int256, and Int512 + their numeral literal suffixes Nov 9, 2024
@SomeGuyWhoLovesCoding
Copy link
Author

The toString() function runs very slow, so I'm rewriting it.

@SomeGuyWhoLovesCoding
Copy link
Author

SomeGuyWhoLovesCoding commented Nov 9, 2024

This pr is now officially closed.

My haxe fork is staying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants