-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use sedlex for utf-8 aware lexing (closes #5163) #6172
Conversation
@andyli Hey, it looks like our ocaml setup on Travis/Linux is not opam-aware, so I have no idea how to install sedlex there? Could we have opam there? |
It's a bit complicated. I will see what I can do. |
Turn out we can still install the opam binary and let it use the system ocaml by adding the
And then all we need to do is to
Tested it locally and it worked well. |
Thanks, I'll try adding that! UPD: that worked! |
I'm fine with merging this as soon as the #6143 people are in a good place. |
Rebased the branch and force-pushed to trigger Travis/Appveyor. |
It's not clear to me what to do to move this forward... |
Basically ask @hughsando if he can run |
Your .merlin change conflicts. |
Fixed. |
I'll go ahead and merge this now. Let me know if there are any problems. |
As we discussed on Slack, I updated my sedlex branch from #5163 (comment). The only thing changed in the lexer since then is the "cache friendly debug line calculus" and the following fix by @ncannasse which were straightforward to add here as well.