Skip to content

[cppia] Fix int overflow in arithmetic assignments #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[cppia] Fix int overflow in arithmetic assignments #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfdc4b5
[cppia] Fix int overflow in arithmetic assignments
tobil4sk Sep 17, 2025
31cde08
[tests] Add regression test for int *= overflow
tobil4sk Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/hx/cppia/Cppia.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,14 @@ struct NAME \
ioVal = left OP f; \
return ioVal; \
} \
inline static int &run(int &ioVal, hx::CppiaCtx *ctx, hx::CppiaExpr *value) \
{ \
int left = ioVal; \
int i = value->runInt(ctx); \
BCR_CHECK_RET(ioVal); \
ioVal = left OP i; \
return ioVal; \
} \
static bool run(bool &ioVal, hx::CppiaCtx *ctx, hx::CppiaExpr *value) { value->runVoid(ctx); return ioVal; } \
static String run(String &ioVal, hx::CppiaCtx *ctx, hx::CppiaExpr *value) { value->runVoid(ctx); return ioVal; } \
static hx::Object *run(hx::Object * &ioVal, hx::CppiaCtx *ctx, hx::CppiaExpr *value) \
Expand Down
8 changes: 8 additions & 0 deletions test/cppia/Client.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ class Client
default:
}

// regression test for #1257
var x = 1290555;
x *= 1290555;
if (x != -915102823) {
Common.status = 'Failed regression test for #1257. x: $x';
return;
}

final extending = new ClientExtendedExtendedRoot();

extending.addValue();
Expand Down
Loading