[Refactor] Extract worker logic out of ProcessEnvironment #913 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breakds
commented
Jul 19, 2021
runjerry
previously approved these changes
Jul 21, 2021
This is part of the effort to unblock #913. Two reasons for this change 1. `worker` definitely does not rely on `ProcessEnvironment` at all, and therefore it is cleaner to make it independent of `ProcessEnvironment`. 2. If it stays as a member method of `ProcessEnvironment`, `multiprocess.Process` will get stuck on `start()` if the parent process is also a `multiprocess.Process`, for unknown reason though (tried investigation but haven't figured out).
breakds
force-pushed
the
PR_extract_proc_env_worker
branch
from
8ba0629
to
ebc64ef
Compare
|
Updated with just a rebase. |
emailweixu
approved these changes
Jul 22, 2021
pd-perry
pushed a commit
to pd-perry/alf
that referenced
this pull request
Dec 11, 2021
…orizonRobotics#939) This is part of the effort to unblock HorizonRobotics#913. Two reasons for this change 1. `worker` definitely does not rely on `ProcessEnvironment` at all, and therefore it is cleaner to make it independent of `ProcessEnvironment`. 2. If it stays as a member method of `ProcessEnvironment`, `multiprocess.Process` will get stuck on `start()` if the parent process is also a `multiprocess.Process`, for unknown reason though (tried investigation but haven't figured out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR that does not incur any logic change
Motivation
This is part of the effort to unblock #913. Two reasons for this change
workerdefinitely does not rely onProcessEnvironmentat all, and therefore it is cleaner to make it independent ofProcessEnvironment.ProcessEnvironment,multiprocess.Processwill get stuck onstart()if the parent process is also amultiprocess.Process, for unknown reason though (tried investigation but haven't figured out).