Skip to content

Conversation

@bennycode
Copy link
Contributor

Hello and a happy new year! 🎉

With this PR the following will be possible when using the Binance API in TypeScript:

import {ErrorCodes} from 'binance-api-node';
console.log('Error code', ErrorCodes.INSUFFICIENT_BALANCE);

@coveralls
Copy link

Coverage Status

Coverage decreased (-26.5%) to 63.971% when pulling 6716a5b on bennyn:patch-2 into 8e35563 on HyperCubeProject:master.

@balthazar balthazar added the types label Jan 3, 2019
@balthazar
Copy link
Collaborator

Hello! Happy New Year! Looks great!

@balthazar
Copy link
Collaborator

Maybe add a little mention in the Readme?

@bennycode
Copy link
Contributor Author

In the readme it's already mentioned (that's how I found it; https://github.com/HyperCubeProject/binance-api-node#errorcodes) but it was never exposed to the TypeScript world.

@balthazar
Copy link
Collaborator

Oh I forgot haha, cool!

@balthazar balthazar merged commit 7971e53 into ccxt:master Jan 3, 2019
@bennycode bennycode deleted the patch-2 branch January 3, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants