More typings #55
More typings #55
Conversation
|
@bennyn Looks good to you? |
| isBuyerMaker: boolean; | ||
| } | ||
|
|
||
| interface MyTrade { |
There was a problem hiding this comment.
Please rename it to Trade to match the naming schema of: https://github.com/binance-exchange/binance-java-api/blob/master/src/main/java/com/binance/api/client/domain/account/Trade.java
There was a problem hiding this comment.
The name Trade is already used for websocket trade events.
index.d.ts
Outdated
| price: string; | ||
| origQty: string; | ||
| executedQty: string; | ||
| status: string; |
There was a problem hiding this comment.
status: string -> status: OrderStatus
| isBestMatch: boolean; | ||
| } | ||
|
|
||
| interface QueryOrderResult { |
There was a problem hiding this comment.
Can interface QueryOrderResult and interface Order be merged?
There was a problem hiding this comment.
No. Order uses transactTime instead of time and provides some additional fields.
| isWorking: boolean; | ||
| } | ||
|
|
||
| interface CancelOrderResult { |
There was a problem hiding this comment.
Is that a Result? To me it looks like a Request because it is created when calling cancelOrder.
The Java API also names it CancelOrderRequest:
There was a problem hiding this comment.
Yes, it is a Result.
|
Thanks for clarification, @mstijak. Approved! |
4 participants
PR for #47