Critical Bugfix - Sometimes, the reactor transport stops working #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `ReactorHttpClient` to use `ReentrantLock` - Fixed a racing condition bug that can lead to unexpected behaviour and following "death" of the reactor transport
|
The actual bug leading to this pull request seems to have been the wrong type of thread used to run the main loop on, after 60 seconds of idling, it automatically gets terminated. This also includes blocking threads. I changed this into using a single thread that only terminates when we explicitly tell it to. |
GrizzlT
changed the title
ConnorLinfoot
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out the reactor transport was bugged due to a mistake in concurrency. Since I'm the author of this particular part of the code I assume I should fix it as well. I have refactored the code using the
java.util.concurrent.lockspackage into safer code while fixing said bug. Fixes #461