Skip to content

Changing the guildExp data type from integer to long #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Changing the guildExp data type from integer to long #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3fc18
Changing the guildExp data type from integer to double
Jul 17, 2022
28db519
Changing the guildExp data type from double to long
Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hypixel-api-core/src/main/java/net/hypixel/api/reply/GuildReply.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static class Guild {
private List<Member> members;
private List<Rank> ranks;
private List<GameType> preferredGames;
private Map<GameType, Integer> guildExpByGameType;
private Map<GameType, Long> guildExpByGameType;
private Map<GuildAchievement, Integer> achievements;
private int coins;
private int coinsEver;
Expand Down Expand Up @@ -202,14 +202,14 @@ public List<GameType> getPreferredGames() {
* @return the amount of XP earned by the guild for the specified {@code game}.
* @throws IllegalArgumentException if the provided {@code game} is {@code null}.
*/
public int getExperienceForGame(GameType game) {
public long getExperienceForGame(GameType game) {
if (game == null) {
throw new IllegalArgumentException("Cannot get XP for null GameType");
}

return Optional.ofNullable(guildExpByGameType)
.map(expByGame -> expByGame.get(game))
.orElse(0);
.orElse(0L);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion hypixel-api-example/src/main/java/net/hypixel/api/example/GetGuildExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ private static void printGuildXpPerGame(Guild guild) {
* Then we loop through each game and see how much experience the guild's earned from it.
*/
for (GameType game : GameType.values()) {
int experienceForGame = guild.getExperienceForGame(game);
long experienceForGame = guild.getExperienceForGame(game);
System.out.println("\t" + game.getName() + ": " + experienceForGame);
}
}
Expand Down