fix: BaseService.Request invoked without result does not close http.Response #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…esponse The method BaseService.Request invoked without result (nil) does not close http.Response and prevents connection to be put back into idle state. We observed significant memory usage or quick MaxConnsPerHost limit exhaustion, when BaseService.Request is called with nil result. Issue: IBM#175 Signed-off-by: Rafał Bigaj <rafal.bigaj@pl.ibm.com>
|
Thanks @padamstx! Is there a way to merge this fix to v5.10.x? |
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
If it is really needed there, then yes, I can work out a way to get it merged into the v5.10 release. But... the current 5.12.x release should be compatible. After I merge the PR into main (it will produce the 5.12.2 release), would you be able to try out that out to see if we can avoid applying the fix to 5.10.x? |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 23, 2023
## [5.12.2](v5.12.1...v5.12.2) (2023-02-23) ### Bug Fixes * BaseService.Request invoked without result does not close http.Response ([#176](#176)) ([a8c0324](a8c0324))
|
🎉 This PR is included in version 5.12.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
BaseService.Requestinvoked without result (nil) does not closehttp.Responseand prevents connection to be put back into idle state.We observed significant memory usage or quick
MaxConnsPerHostlimit exhaustion, whenBaseService.Requestis called withnilresult.Issue: #175