Skip to content

Conversation

padamstx
Copy link
Contributor

This commit modifies the project so that our mininum supported version of Go is now 1.18.

@padamstx padamstx self-assigned this Feb 23, 2023
@padamstx padamstx requested review from dpopp07 and pyrooka February 23, 2023 19:56
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx
Copy link
Contributor Author

I'm re-requesting reviews because I just pushed an amended commit that removes the v5 directory. I've been thinking about that change for a while and now that we're moving up to a new go version, it seemed like the right time to do it.

@padamstx padamstx requested review from dpopp07 and pyrooka February 23, 2023 21:26
@padamstx padamstx force-pushed the bump-go branch 5 times, most recently from b7a8ecc to c629150 Compare February 23, 2023 23:17
This commit modifies the project so that our mininum
supported version of Go is now 1.18.
As part of this commit, I also removed the v5
directory and moved its contents up to the project root.
This should simplify things a bit and won't affect users
at all.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit 4648b07 into main Feb 24, 2023
@padamstx padamstx deleted the bump-go branch February 24, 2023 16:22
ibm-devx-sdk pushed a commit that referenced this pull request Feb 24, 2023
# [5.13.0](v5.12.2...v5.13.0) (2023-02-24)

### Bug Fixes

* fix v5-related errors ([#178](#178)) ([e8e20a3](e8e20a3))
* remove CONTRIBUTING.md from bump2version config ([#179](#179)) ([4d610bb](4d610bb))

### Features

* bump minimum go version to 1.18 ([#177](#177)) ([4648b07](4648b07))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants