-
Notifications
You must be signed in to change notification settings - Fork 28
feat: bump minimum go version to 1.18 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm re-requesting reviews because I just pushed an amended commit that removes the v5 directory. I've been thinking about that change for a while and now that we're moving up to a new go version, it seemed like the right time to do it. |
b7a8ecc
to
c629150
Compare
This commit modifies the project so that our mininum supported version of Go is now 1.18. As part of this commit, I also removed the v5 directory and moved its contents up to the project root. This should simplify things a bit and won't affect users at all. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
🎉 This PR is included in version 5.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This commit modifies the project so that our mininum supported version of Go is now 1.18.