fix(errors): wrap errors from external authenticators to use new system #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External authenticators may not use our error types. We previously assumed that errors coming from the `Authenticate` method would be either an `AuthenticationError` or `SDKProblem` and performed a type-cast that could cause a panic. This makes the type checking more explicit, and in the case of an unexpected error type, wraps the error in a new SDKProblem object and returns it to keep our error types consistent. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Apr 8, 2024
## [5.16.4](v5.16.3...v5.16.4) (2024-04-08) ### Bug Fixes * **errors:** wrap errors from external authenticators to use new system ([#214](#214)) ([c74778e](c74778e))
|
🎉 This PR is included in version 5.16.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External authenticators may not use our error types. We previously assumed that errors coming from the
Authenticatemethod would be either anAuthenticationErrororSDKProblemand performed a type-cast that could cause a panic. This makes the type checking more explicit, and in the case of an unexpected error type, wraps the error in a new SDKProblem object and returns it to keep our error types consistent.