Skip to content

Conversation

@Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 23, 2021

PR summary

This PR adds labels to example output, so it is easier to identify which output section belongs to which method.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi self-assigned this Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #94 (aacb23e) into main (4a3c7fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          21       21           
  Lines       20022    20022           
=======================================
  Hits        18738    18738           
  Misses       1284     1284           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3c7fc...aacb23e. Read the comment docs.

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks good.

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, but let's discuss my suggestion.

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 00c285a into main Mar 25, 2021
@padamstx padamstx deleted the fix-add-labels-to-examples branch March 25, 2021 13:57
ibm-devx-automation pushed a commit that referenced this pull request Mar 25, 2021
## [0.17.17](v0.17.16...v0.17.17) (2021-03-25)

### Bug Fixes

* add labels to examples ([#94](#94)) ([00c285a](00c285a))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.17 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants